Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to get builtin globals #207

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jan 6, 2024

No description provided.

@sindresorhus
Copy link
Owner

It doesn't seem to actually work. I tried removing "eval": false, from "builtin" and then run the script, and it did not get added back.

@sindresorhus
Copy link
Owner

Can you add the script to package.json run script?

@sindresorhus
Copy link
Owner

This would have been more maintainable by using CSS selectors instead of regex.

@fisker
Copy link
Collaborator Author

fisker commented Jan 19, 2024

Can you try again?

@fisker
Copy link
Collaborator Author

fisker commented Jan 19, 2024

My main purpose is actually to make this script runnable from node.

I found there seems in many spec files. Maybe we can try puppeteer?

@sindresorhus
Copy link
Owner

Works great now 👍

@sindresorhus
Copy link
Owner

Can you add the script to package.json run script?

⬆️

@sindresorhus
Copy link
Owner

sindresorhus commented Jan 24, 2024

I found there seems in many spec files. Maybe we can try puppeteer?

👍

I still prefer to keep cheerio for the current script though.

@sindresorhus sindresorhus merged commit d9bef83 into sindresorhus:main Jan 24, 2024
3 checks passed
@fisker fisker deleted the builtin-globals branch January 24, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants