Generate types rather than relying on type-fest
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Feb 3, 2024
sindresorhus
reviewed
Feb 3, 2024
sindresorhus
requested changes
Feb 9, 2024
|
@sindresorhus Done ✔️ Also, I see that there's an |
I think that's a mistake. It should run |
|
Got tsd running, and that was good as that uncovered what would had been a regression, now fixed the generated types to look more like the old ones |
|
Now... I'm way to trigger-happy today, sorry |
voxpelli
added a commit
to voxpelli/eslintrc
that referenced
this pull request
Feb 12, 2024
Only breaking change is the dropping of old Node.js versions but it still support all versions that `@eslint/eslintrc` supports. The one impactful thing it does though is that it removes the only dependency – replacing an outdated `type-fest` module with built-in types – making it so that everyone that installs `eslint` doesn't also get an outdated `type-fest` and thus doesn't have to contend with it in their `npm` deduping and hoisting. Relevant PR: sindresorhus/globals#209
nzakas
pushed a commit
to eslint/eslintrc
that referenced
this pull request
Feb 12, 2024
Maintenance update of `globals` to `v14` Only breaking change is the dropping of old Node.js versions but it still support all versions that `@eslint/eslintrc` supports. The one impactful thing it does though is that it removes the only dependency – replacing an outdated `type-fest` module with built-in types – making it so that everyone that installs `eslint` doesn't also get an outdated `type-fest` and thus doesn't have to contend with it in their `npm` deduping and hoisting. Relevant PR: sindresorhus/globals#209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was first going to update this repository to use the latest
type-fest(^4.10.2) instead of the old^0.20.2, but then I thought: Why doReadonlyDeep<>on the fly, with input from a JSON-file, when we can just as well generate it up front instead?So I threw together a quick script that generates a
readonlystructure usinginterface:s.Should probably do something that automates this generation, any specific way you would prefer?
(Found this as I found that ESLint is relying on this module and thus that an old
type-festis pulled in to all of my projects)Fixes #208