Destroy request object after successful response (#2187)

sindresorhus · Dec 7, 2022 · 2d1497e · 2d1497e
1 parent 5e17bb7
commit 2d1497e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/source/as-promise/index.ts b/source/as-promise/index.ts
@@ -131,6 +131,7 @@ export default function asPromise<T>(normalizedOptions: NormalizedOptions): Canc
 					return;
 				}
 
+				request.destroy();
 				resolve(request.options.resolveBodyOnly ? response.body as T : response as unknown as T);
 			});
 

diff --git a/test/promise.ts b/test/promise.ts
@@ -95,3 +95,14 @@ test('promise.json() does not fail when server returns an error and throwHttpErr
 	const promise = got('', {throwHttpErrors: false});
 	await t.notThrowsAsync(promise.json());
 });
+
+test('the request is destroyed once the promise has resolved', withServer, async (t, server, got) => {
+	server.get('/', (_request, response) => {
+		response.statusCode = 200;
+		response.end('null');
+	});
+
+	const {request} = await got('');
+
+	t.true(request.destroyed);
+});