Correctly forward stream errors (#424)

Related to #388
sindresorhus · Nov 22, 2017 · 974473a · 974473a
1 parent 9495256
commit 974473a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -416,6 +416,10 @@ function asStream(opts) {
 
  const statusCode = res.statusCode;
 
+ res.on('error', err => {
+ proxy.emit('error', new got.ReadError(err, opts));
+ });
+
  res.pipe(output);
 
  if (statusCode !== 304 && (statusCode < 200 || statusCode > 299)) {

diff --git a/test/gzip.js b/test/gzip.js
@@ -66,6 +66,13 @@ test('handles gzip error', async t => {
  t.is(err.name, 'ReadError');
 });
 
+test('handles gzip error - stream', async t => {
+ const err = await t.throws(getStream(got.stream(`${s.url}/corrupted`)));
+ t.is(err.message, 'incorrect header check');
+ t.is(err.path, '/corrupted');
+ t.is(err.name, 'ReadError');
+});
+
 test('decompress option opts out of decompressing', async t => {
  const response = await got(s.url, {decompress: false});
  t.true(Buffer.compare(response.body, gzipData) === 0);