Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Premature close stream error on Node.js v13.5.0 #1003

Closed
szmarczak opened this issue Dec 19, 2019 · 5 comments
Closed

Uncaught Premature close stream error on Node.js v13.5.0 #1003

szmarczak opened this issue Dec 19, 2019 · 5 comments
Labels
bug Something does not work as it should external The issue related to an external project

Comments

@szmarczak
Copy link
Collaborator

From https://travis-ci.org/sindresorhus/got/jobs/627203773

...
  Uncaught exception in test/stream.ts
  /home/travis/build/sindresorhus/got/node_modules/@szmarczak/http-timer/source/index.ts:75
  Error [ERR_STREAM_PREMATURE_CLOSE]: Premature close
...
  1 test failed
  1 test skipped
  1 uncaught exception
  gzip.ts › handles gzip error - stream
  /home/travis/build/sindresorhus/got/test/gzip.ts:51
   50:                                                   
   51:   await t.throwsAsync(getStream(got.stream('')), {
   52:     name: 'ReadError',                            
  Promise rejected with unexpected exception:
  Error {
    bufferedData: '',
    code: 'Z_DATA_ERROR',
    errno: -3,
    message: 'incorrect header check',
  }
  Expected name to equal:
  'ReadError'
@szmarczak szmarczak added bug Something does not work as it should ✭ help wanted ✭ labels Dec 19, 2019
@szmarczak
Copy link
Collaborator Author

Ah, forgot about #990

@szmarczak szmarczak reopened this Dec 19, 2019
@szmarczak
Copy link
Collaborator Author

Actually this is still happening somehow: https://travis-ci.org/sindresorhus/got/jobs/627255765

@szmarczak
Copy link
Collaborator Author

Indeed. Something in Node.js core changed. I upgraded my local Node.js from v13.0.1 to v13.5.0 and it fails on my side too.

@szmarczak szmarczak changed the title Uncaught Premature close stream error Uncaught Premature close stream error on Node.js v13.5.0 Dec 19, 2019
@szmarczak
Copy link
Collaborator Author

See nodejs/node#31029

@szmarczak szmarczak added external The issue related to an external project and removed ✭ help wanted ✭ labels Dec 19, 2019
@szmarczak
Copy link
Collaborator Author

Fixed in v13.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as it should external The issue related to an external project
Projects
None yet
Development

No branches or pull requests

1 participant