Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protocol to error messages #249

Closed
reconbot opened this issue Dec 18, 2016 · 1 comment · Fixed by renovatebot/renovate#223
Closed

Add protocol to error messages #249

reconbot opened this issue Dec 18, 2016 · 1 comment · Fixed by renovatebot/renovate#223
Labels
enhancement This change will extend Got features ✭ help wanted ✭

Comments

@reconbot
Copy link
Contributor

https://github.com/sindresorhus/got/blob/master/index.js#L339 has a bunch of request settings copied into the error object. The protocol would also be helpful.
@sindresorhus
Copy link
Owner

👍 Pull request welcome :)

@sindresorhus sindresorhus added enhancement This change will extend Got features ✭ help wanted ✭ labels Feb 6, 2017
alextes added a commit to alextes/got that referenced this issue Mar 8, 2017
@alextes
Add protocol to stdError object
7f7f8a4 
Adds the protocol to the stdError object got uses for all it's errors.
Closes sindresorhus#249.
alextes added a commit to alextes/got that referenced this issue Mar 8, 2017
@alextes
Add protocol to stdError object
1f667ec 
Adds the protocol to the stdError object got uses for all its errors.
Closes sindresorhus#249.
@alextes alextes mentioned this issue Mar 8, 2017
Merged
alextes added a commit to alextes/got that referenced this issue Mar 8, 2017
@alextes
Add protocol to stdError object
461a21a 
Adds the protocol to the stdError object got uses for all its errors.
Closes sindresorhus#249.
sindresorhus pushed a commit that referenced this issue Mar 8, 2017
@alextes @sindresorhus
Add protocol to stdError (#277)
919703c 
* Add protocol property to error properties test

* Add protocol to stdError object

Adds the protocol to the stdError object got uses for all its errors.
Closes #249.
This was referenced May 29, 2017
Closed
Merged
@MaxMood96 MaxMood96 mentioned this issue Jul 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This change will extend Got features ✭ help wanted ✭
Projects
None yet
Milestone
No milestone
2 participants
@reconbot @sindresorhus