Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option allowGetBody to allow GET requests with payload #1081

Merged
merged 13 commits into from
Feb 20, 2020
Merged

Add option allowGetBody to allow GET requests with payload #1081

merged 13 commits into from
Feb 20, 2020

Conversation

dopecodez
Copy link
Contributor

@dopecodez dopecodez commented Feb 19, 2020 •
edited
Loading

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates.

Fix for #1074

@dopecodez dopecodez requested review from sindresorhus and szmarczak and removed request for sindresorhus February 19, 2020 15:15
@dopecodez dopecodez mentioned this pull request Feb 19, 2020
Closed
szmarczak
szmarczak reviewed Feb 19, 2020
View reviewed changes
test/arguments.ts Outdated Show resolved Hide resolved
szmarczak
szmarczak requested changes Feb 19, 2020
View reviewed changes
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
source/normalize-arguments.ts Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Feb 19, 2020
View reviewed changes
readme.md Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Feb 19, 2020
View reviewed changes
test/arguments.ts Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Feb 19, 2020
View reviewed changes
test/post.ts Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Feature: Added option allowGetBody for allowing GET requests with payload Add option allowGetBody to allow GET requests with payload Feb 19, 2020
dopecodez and others added 9 commits February 20, 2020 10:41
@dopecodez @sindresorhus
Update test/arguments.ts
ad4242a 
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
@dopecodez @sindresorhus
Update test/post.ts
5f487ce 
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
@dopecodez @szmarczak
Update source/normalize-arguments.ts
eb0bd61 
Co-Authored-By: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
@dopecodez @szmarczak
Update readme.md
f13dae9 
Co-Authored-By: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
@dopecodez @szmarczak
Update test/arguments.ts
7d80747 
Co-Authored-By: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
@dopecodez @szmarczak
Update readme.md
152c1c3 
Co-Authored-By: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>
@dopecodez
Update readme.md
ae10bfb
@dopecodez
Update post.ts
4e6e094
@dopecodez
Update readme.md
ce123e9
@sindresorhus sindresorhus merged commit 526b4bb into sindresorhus:master Feb 20, 2020
@sindresorhus
Copy link
Owner

Nice work, @dopecodez 👍

@szmarczak szmarczak mentioned this pull request Feb 20, 2020
Merged
18 tasks
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
This was referenced Feb 25, 2022
Merged
Merged
Merged
@withshubh withshubh mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmarczak szmarczak szmarczak approved these changes

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dopecodez @sindresorhus @szmarczak