-
-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Node.js 12 #1575
Require Node.js 12 #1575
Conversation
@szmarczak I tried to remove Lines 1391 to 1392 in 2369580
|
Let me see... |
|
I'm not really sure why but this line fails on Node.js 12 only: https://github.com/nodejs/node/blob/v12.20.1/lib/_http_client.js#L472 only when running timeout tests. If a timeout gets breached then Node.js throws that assertion error. |
That's an issue in
This is also an existing issue in |
Node.js 10 is soon out of LTS (in April), so I think it makes sense to do it for this major release.
This PR also prepares us for ESM. The ESM move is blocked by: avajs/typescript#5 (comment)