Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update comparison table for node-fetch@3 #1950

Closed
wants to merge 2 commits into from
Closed

Conversation

ziv
Copy link

@ziv ziv commented Dec 13, 2021

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests. (no tests needed)
  • If it's a new feature, I have included documentation updates in both the README and the types.

No code changes, not tests added.
This PR is update the comparison table to add node-fetch version 3 new features.

  1. node-fetch support for HTTP2
  2. node-fetch support Advanced timeouts using AbortController

@sindresorhus
Copy link
Owner

Please link to sources that confirm your assertions.

readme.md Outdated Show resolved Hide resolved
@@ -182,7 +182,7 @@ For advanced JSON usage, check out the [`parseJson`](documentation/2-options.md#
| Retries on failure | :heavy_check_mark: | :x: | :x: | :heavy_check_mark: | :x: | :heavy_check_mark: |
| Progress events | :heavy_check_mark: | :x: | :x: | :heavy_check_mark:\*\*\* | Browser only | :heavy_check_mark: |
| Handles gzip/deflate | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: |
| Advanced timeouts | :heavy_check_mark: | :x: | :x: | :x: | :x: | :x: |
| Advanced timeouts | :heavy_check_mark: | :x: | :heavy_check_mark: | :x: | :x: | :x: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any advanced timeouts usage. Can you provide a reference please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just normal timeout which all HTTP kind support, as far as I can see.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll close this PR

@ziv
Copy link
Author

ziv commented Dec 13, 2021

  1. I remove the mistake regarding HTTP2 (was in the roadmap and I missed the fact it left out of version 3).
  2. Timeouts using AbortController the same way window.fetch do:
    https://github.com/node-fetch/node-fetch#request-cancellation-with-abortsignal

@ziv ziv closed this Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants