Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying undefined for options #2258

Merged
merged 2 commits into from
May 27, 2023
Merged

Allow specifying undefined for options #2258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52bb1ea
Add failing tests for #2257
WillianAgostini Apr 30, 2023
d957f19
fix: allow undefined on agent property
WillianAgostini Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion source/core/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,13 @@ export default class Options {
}

// @ts-expect-error Type 'unknown' is not assignable to type 'never'.
this[key as keyof Options] = options[key as keyof Options];
const value = options[key as keyof Options];
if (value === undefined) {
continue;
}

// @ts-expect-error Type 'unknown' is not assignable to type 'never'.
this[key as keyof Options] = value;

push = true;
}
Expand Down
14 changes: 14 additions & 0 deletions test/agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,3 +205,17 @@ test('no socket hung up regression', withServer, async (t, server, got) => {

agent.destroy();
});

test('accept undefined agent', withServer, async (t, server, got) => {
server.get('/', (_request, response) => {
response.end('ok');
});

const undefinedAgent = undefined;
t.truthy((await got({
https: {
rejectUnauthorized: false,
},
agent: undefinedAgent,
})).body);
});