Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #2378

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Patch 1 #2378

merged 2 commits into from
Sep 16, 2024

Conversation

dscotese
Copy link
Contributor

Lowercased two inappropriately caliptalized occurrences of "foo". I wasn't sure if this was correct so I asked an AI (Gemini) which explained that while HTTP headers are case insensitive, the property names of Javascript objects are not, so foo and Foo are different and the code was asking for the wrong one.

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types.

@sindresorhus sindresorhus merged commit 89b7fdf into sindresorhus:main Sep 16, 2024
1 check passed
sevteen pushed a commit to sevteen/got-cjs that referenced this pull request Oct 28, 2024
@dscotese dscotese deleted the patch-1 branch December 14, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants