Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make (more) sure the error we get is the one we expect #267

Merged
merged 2 commits into from
Feb 14, 2017
Merged

Make (more) sure the error we get is the one we expect #267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b746624
Make (more) sure the error we get is the one we expect
alextes Jan 23, 2017
cf6e25a
Simplify test per Sindre's suggestion.
alextes Jan 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions test/json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,8 @@ test('catches errors on invalid non-200 responses', async t => {
});

test('should have statusCode in err', async t => {
try {
await got(`${s.url}/non200-invalid`, {json: true});
t.fail('Exception was not thrown');
} catch (err) {
t.is(err.statusCode, 500);
}
const err = await t.throws(got(`${s.url}/non200-invalid`, {json: true}), got.ParseError);
t.is(err.statusCode, 500);
});

test.after('cleanup', async () => {
Expand Down