Enable the 'noUnusedParameters' TypeScript setting #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes `noUnusedParameters: false`, one of the tasks in the checklist at sindresorhus#758. After reading these documents, it seems like either `_` or e.g. `_unusedRequest` is a good replacement name which silences the errors for these parameters - microsoft/TypeScript#24249 - microsoft/TypeScript#9458
| @@ -14,11 +14,11 @@ test.before('setup', async () => { | |||
|
|
|||
| // HTTPS Handlers | |||
|
|
|||
| https.on('/', (request, response) => { | |||
| https.on('/', (_unusedRequest, response) => { | |||
There was a problem hiding this comment.
I think just _request would be better.
There was a problem hiding this comment.
Sure, I'll change it if you'd like. I went with this because with _request, it seems likely that if in the future the code were changed and did start to use the parameter, the programmer likely would not know to remove the underscore. Whereas if you start calling things on _unusedRequest it screams that the name should be changed.
|
Sorry, this was made moot by #765. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
noUnusedParameters: false, one of the tasks in the checklist at #758.After reading these documents, it seems like either
_or e.g._unusedRequestis a good replacement name which silences the errors for these parametersLooking forward to comments, and curious if you have another way in mind.
Checklist