Allow functions as shorthand commands #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI would break with more recent versions of xo as grunt-shell has to support node v4.
|
Sorry for the PR after two years ^^ I fixed CI errors. If you prefer setting the node engine to |
|
@sindresorhus hello, do you think there's any chance this could be merged ? |
|
Sorry for the delay. Thanks for fixing this :) |
|
No problem, thanks for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation declares
commandas being of type string or Function, and states that it can be "omitted by directly setting the target with the command". It made me believe that I could directly pass a function as a target, but this actually only works for strings. This PR allows passing a function as target and omittingcommand.