Replace jpegtran with mozjpeg #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the 6th commit i meant "fixture.jpg", not "fixture.png" |
|
Thanks :) |
ahmadalfy
added a commit
to ahmadalfy/workflow
that referenced
this pull request
Feb 15, 2020
|
Hi guys, sorry I'm late to the party. Are images still compressed in a lossless way? Afaik jpegtran did not recompress images, only remove metadata. If I omit the 'quality' option from mozjpeg, will it work in the same way or does it just default to its 75 setting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I finished working on switch from jpegtran to Mozilla's mozjpeg and everything seems to work fine.
See the diff.
Fixes #333