Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add opts option and default behavior #119

Closed
wants to merge 1 commit into from

Conversation

bemble
Copy link

@bemble bemble commented Dec 20, 2015

In reply to the issue #44, I add the ability to get the default options from a mocha opts file.
By default it takes the default path of mocha, test/mocha.opts but users can define another path thanks to the opts option.
Last thing, it still working if the file is not found.

@sindresorhus
Copy link
Owner

As commented in #44, this should be fixed in Mocha, not here.

@bemble
Copy link
Author

bemble commented Dec 21, 2015

@sindresorhus I totally agree with, but for now I see two points: as you probably already know, the way mocha handles opts is quiet dirty (shortly, the opts file is read and the opts are added to the current process so mocha standard behavior can work) so we have to wait until they refactor all that part, which brings me the second point, we don't know if they will refactor this, soon or not, according to the issue here mochajs/mocha#1457.

@sindresorhus
Copy link
Owner

Alright, but least make it a module that can be depended upon here so I don't have to maintain all this code.

@shellscape
Copy link
Contributor

closing on age and last comment by @sindresorhus

@shellscape shellscape closed this Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants