Support import.meta.url
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| const filenameInLocalNodeModules = !path.relative(localNodeModules, filename).startsWith('..') && | ||
| // On Windows, if `localNodeModules` and `filename` are on different partitions, `path.relative()` returns the value of `filename`, resulting in `filenameInLocalNodeModules` incorrectly becoming `true`. | ||
| path.parse(localNodeModules).root === path.parse(filename).root; | ||
| const filenameInLocalNodeModules = !path.relative(localNodeModules, normalizedFilename).startsWith('..') && |
There was a problem hiding this comment.
Please don't make unrelated changes (the indentation).
There was a problem hiding this comment.
sorry, my fault. now, my modifications follow the lint information
|
This is not fixing anything as You also need to update the readme to mention support for |
yKanon
changed the title
alright. So, does big brother means that it is a feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description: use
import.meta.urlwhen use esmodule. but its value is 'file://xxxx'. so,globalDirreturnundefine, andpath.relativethrow Error