Fix regression with preferring local install when invoked through global CLI #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes the issue described in avajs/ava#2168, and adds a regression test
sindresorhus
changed the title
|
Thanks for fixing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in avajs/ava#2168.
The problem was that I was using
findUp.syncto detect whether the localnode_modulesis a parent directory ofglobalDir. I expected that function to only return true when the path in the first argument was found while traversing up the directory tree, but because we provide an absolute path, it actually always returned true.This wasn't caught in CI because there's no test where we invoke a global CLI, but want to resolve to a version in the local node_modules, so I've added a regression test.
@sindresorhus @novemberborn: In addition to these tests, I've verified that the "prefers local version of ava" test passes in ava when linked to this branch.