Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow self-closing SVG tag #18

Merged
merged 1 commit into from
May 30, 2019
Merged

Allow self-closing SVG tag #18

merged 1 commit into from
May 30, 2019

Conversation

tprobinson
Copy link
Contributor

Test cases added as well.

JSPerf test against the strings in the test suite here: https://jsperf.com/svg-regex-performance/1

@tprobinson
Copy link
Contributor Author

PR updated against master

@sindresorhus
Copy link
Owner

I don't think you fixed the merge conflict correctly. Look at the diff. Lots of unrelated changes included.

@tprobinson tprobinson closed this May 29, 2019
@tprobinson tprobinson reopened this May 29, 2019
@tprobinson
Copy link
Contributor Author

tprobinson commented May 29, 2019

Sorry about that! I gave this another shot by just re-applying my changes to your master branch which eliminated those extra changes.

@sindresorhus sindresorhus changed the title Allow self-closing SVG tag. Allow self-closing SVG tag May 30, 2019
@sindresorhus sindresorhus merged commit 23d6d27 into sindresorhus:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants