-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow input to start with slash by removing head slashes #561
base: main
Are you sure you want to change the base?
Allow input to start with slash by removing head slashes #561
Conversation
by replacing slashes at the start of the input
15ef69e
to
cb89702
Compare
From the docs:
|
I see. Could it be something "discouraged", rather than something "disallowed"? From the little I saw, I don't see how this change could break things in the library. 🙈 |
There's been a lot of discussion on this before in the issues and previous PRs. It's easily the most controversial part of Ky. Basically, it's an opinionated choice meant to make it abundantly clear that the FWIW, my stance on this has softened because of how many people complain about it. I'd like to find a way to satisfy everyone. |
While I agree with the relative-vs-root argument, most REST API docs show the endpoints as
Those I found that don't follow the format, it's just because they show the full URL (Google APIs, Microsoft APIs) |
See PR #606 for my proposed solution. |
is there any progress on this? |
No but it's very much on our radar. I still have a bit of work to do on #606 before it's finalized. When it is ready, I want to discuss which approach is preferred and hopefully merge one or the other. I like having both PRs to look at so the discussion is less abstract. |
I prefer this PR to #606, just remove that Workaround: |
input
param to start with slash (/
) by removing head slashes