Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace loud-rejection with hard-rejection? #93

Closed
shesek opened this issue Jul 18, 2018 · 2 comments
Closed

Replace loud-rejection with hard-rejection? #93

shesek opened this issue Jul 18, 2018 · 2 comments

Comments

@shesek
Copy link

shesek commented Jul 18, 2018

loud-rejection was changed to log the errors when the process exits, and not as they happen. For long-running scripts like server daemons, this means that errors goes unprinted until the process gets killed by some other means.

It appears like hard-rejection, by the same author, might be more appropriate for meow? Or possibly, support both and make it configurable?

More info from the README: https://github.com/sindresorhus/loud-rejection#%EF%B8%8F--breaking-change-in-minor-version

Discussion on the rational of the two approaches: sindresorhus/loud-rejection#19

@shesek
Copy link
Author

shesek commented Jul 18, 2018

Just realized that meow, loud-rejection and hard-rejection are all authored by @sindresorhus, meaning that this is probably an intentional choice. Closing, will open a separate issue for a different request.

@shesek shesek closed this as completed Jul 18, 2018
sindresorhus added a commit that referenced this issue Nov 5, 2018
The difference is that now it will crash the process right away on unhandled promises instead of waiting until the process exits.

Fixes #93
@shesek
Copy link
Author

shesek commented Nov 7, 2018

Sweet, thanks! That's something I need pretty much every time I use meow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant