Remove <abbr> reset #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sindresorhus I swear I am done now if you want to release a new version ;) |
germanfrelo
added a commit
to germanfrelo/base-css-stylesheet
that referenced
this pull request
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reset has never worked because Safari doesn't support the specific shorthand we use. You can check out the implementation bug here: https://bugs.webkit.org/show_bug.cgi?id=230083
We could add a workaround to render an underline in Safari, but we don't have to because the next version of Safari will come with a baked-in workaround: https://bugs.webkit.org/show_bug.cgi?id=277889
It could take many months for the fix to be merged and released for us to test, so I think the best course of action is to remove this reset now, and then open an issue to track that the workaround is indeed present in the next version of Safari: #87