Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve promise iteration logic #40

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Improve promise iteration logic #40

merged 1 commit into from
Aug 27, 2024

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Aug 27, 2024

This PR improves promise[Symbol.asyncIterator] logic, fixing a few bugs including:

  • Currently, each stdout line waits for one stderr line, and vice-versa
  • The underlying iterator.return() and iterator.throw() are not called, which means try { ... } finally { await resultPromise } was not called when calling for await (line of nanoSpawn(...)) { ...; break; }

The PR also adds more tests.

@sindresorhus sindresorhus merged commit 5f449e1 into main Aug 27, 2024
12 checks passed
@sindresorhus sindresorhus deleted the iterable-all branch August 27, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants