Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
promise[Symbol.asyncIterator]
logic, fixing a few bugs including:stdout
line waits for onestderr
line, and vice-versaiterator.return()
anditerator.throw()
are not called, which meanstry { ... } finally { await resultPromise }
was not called when callingfor await (line of nanoSpawn(...)) { ...; break; }
The PR also adds more tests.