Decrease package size #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Sep 5, 2024
| @@ -57,7 +53,7 @@ const getErrorInstance = (error, {command}) => error?.message.startsWith('Comman | |||
|
|
|||
| const getErrorOutput = ({exitCode, signalCode}) => ({ | |||
| // `exitCode` can be a negative number (`errno`) when the `error` event is emitted on the `instance` | |||
| ...(exitCode === null || exitCode < 1 ? {} : {exitCode}), | |||
There was a problem hiding this comment.
null < 1 is true :)
ehmicky
force-pushed
the
refactor
branch
6 times, most recently
from
3817682 to
7f90d40
Compare
ehmicky
commented
Sep 5, 2024
| @@ -69,6 +65,6 @@ const getOutputs = ({state: {stdout, stderr, output}, command, start}) => ({ | |||
| durationMs: Number(process.hrtime.bigint() - start) / 1e6, | |||
| }); | |||
|
|
|||
| const getOutput = input => input?.at(-1) === '\n' | |||
There was a problem hiding this comment.
That ?. is not needed since the argument is always a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the codebase to remove a few bytes from the package size.