Fix handling of protocol-less URLs with a port

Fixes #187 Closes #186
sindresorhus · Mar 10, 2024 · dec5dc6 · dec5dc6
1 parent 12e3b1b
commit dec5dc6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -13,7 +13,10 @@ const supportedProtocols = new Set([
 const hasCustomProtocol = urlString => {
 	try {
 		const {protocol} = new URL(urlString);
-		return protocol.endsWith(':') && !supportedProtocols.has(protocol);
+
+		return protocol.endsWith(':')
+			&& !protocol.includes('.')
+			&& !supportedProtocols.has(protocol);
 	} catch {
 		return false;
 	}

diff --git a/test.js b/test.js
@@ -39,6 +39,7 @@ test('main', t => {
 	// t.is(normalizeUrl('sindre://www.sorhus.com/'), 'sindre://sorhus.com');
 	// t.is(normalizeUrl('sindre://www.sorhus.com/foo/bar'), 'sindre://sorhus.com/foo/bar');
 	t.is(normalizeUrl('https://i.vimeocdn.com/filter/overlay?src0=https://i.vimeocdn.com/video/598160082_1280x720.jpg&src1=https://f.vimeocdn.com/images_v6/share/play_icon_overlay.png'), 'https://i.vimeocdn.com/filter/overlay?src0=https://i.vimeocdn.com/video/598160082_1280x720.jpg&src1=https://f.vimeocdn.com/images_v6/share/play_icon_overlay.png');
+	t.is(normalizeUrl('sindresorhus.com:123'), 'http://sindresorhus.com:123');
 });
 
 test('defaultProtocol option', t => {