Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add remove explicit port option #174

Merged
merged 4 commits into from
Sep 27, 2022
Merged

Feat: add remove explicit port option #174

merged 4 commits into from
Sep 27, 2022

Conversation

ianizaguirre
Copy link
Contributor

@ianizaguirre ianizaguirre commented Sep 6, 2022 •
edited by sindresorhus
Loading

Feature added: Removes a port number corresponding to the protocol part of a url, excluding a default port number e.g., 80 for http, and 443 for https.

Fixes #171

@ianizaguirre ianizaguirre mentioned this pull request Sep 6, 2022
Closed
@ianizaguirre
Copy link
Contributor Author

@sindresorhus just following up

@ianizaguirre
Copy link
Contributor Author

@Vladisvob

Hello,
Do you have the ability to merge this, or are we waiting for another review?

sindresorhus
sindresorhus requested changes Sep 22, 2022
View reviewed changes
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
@sindresorhus sindresorhus merged commit 192223b into sindresorhus:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add removePort option
2 participants
@ianizaguirre @sindresorhus