Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Uncaught (in promise) TypeError: Failed to construct 'URL': Invalid URL #288

Closed
Malix-Labs opened this issue Feb 9, 2024 · 2 comments · Fixed by #294
Closed

Bug: Uncaught (in promise) TypeError: Failed to construct 'URL': Invalid URL #288

Malix-Labs opened this issue Feb 9, 2024 · 2 comments · Fixed by #294

Comments

@Malix-Labs
Copy link

Malix-Labs commented Feb 9, 2024

Uncaught (in promise) TypeError: Failed to construct 'URL': Invalid URL

Context

background.js:2576 (anonymous function)

image

@Malix-Labs
Copy link
Author

Malix-Labs commented Feb 16, 2024

Problem Found

The extension silently fatal error when the "GitHub URL Entreprise Link" field is blank.
This needs to be fixed.

Workaround

Fill "https://github.com" as the GitHub URL Entreprise Link.

@Malix-Labs
Copy link
Author

Malix-Labs commented Apr 21, 2024

@notlmn wouldn't it be better if it'd work without specifying the URL for the people that doesn't use Entreprise GitHub (the vast majority), instead of saying what needs to be there to not fatal error with a comment in the setting page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant