Only register the notification click handler once #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the anonymous inline function used as the handler for `browser.notification.onClicked.addListener` with a named function, to avoid re-registering the same handler on every call to `addHandlers`. Note that `addEventListener` called repeatedly with the same arguments will not register the same event listener multiple times (see the `EventTarget.addEventListener` spec[0] for more info). This means that using the same named function for each call to `addHandlers` will only call that function once, where the previous code added a new anonymous function for each call. This fixes sindresorhus#234, where clicking a notification would result in multiple tabs being opened, depending on the number of times that `addHandlers` was called [0]: https://www.w3.org/TR/2000/REC-DOM-Level-2-Events-20001113/events.html#Events-EventTarget-addEventListener
|
Linting is failing |
notlmn
requested changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the handler for
browser.notification.onClicked.addListenerwith a named function, which avoids re-registering the handler on every call toaddHandlers.Note that
addEventListenercalled repeatedly with the same arguments will not register the same event listener multiple times (see theEventTarget.addEventListenerspec for more info). This means that using the same named function for each call toaddHandlerswill only call that function once, where the previous code added a new anonymous function for each call.This fixes #234, where clicking a notification would result in multiple tabs being opened, depending on the number of times that
addHandlerswas called.