Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification sound not playing #274

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Fix notification sound not playing #274

merged 1 commit into from
Feb 6, 2023

Conversation

notlmn
Copy link
Collaborator

@notlmn notlmn commented Feb 6, 2023

Fixes #272

@notlmn notlmn merged commit 7a01849 into main Feb 6, 2023
@notlmn notlmn deleted the bell branch February 6, 2023 15:15
@jeesim2
Copy link

jeesim2 commented Feb 10, 2023

@notlmn
Today I spent 2 hours to figure out what apps started to play sound on my macbook from yesterday,
and finally check this plugin that totally forgotten in my mind.
(the sound played very often, once~several times a minute even though there is no new notifications on github)

After I installed this plugin a year ago there were no sound notification.
Because It was such a long time ago, today I couldn't consider this plugin as the sound source.

I guess many users who installed this plugin long time ago might fall in problem to find the sound source.

@notlmn
Copy link
Collaborator Author

notlmn commented Feb 17, 2023

If you think there is a bug with the behavior documented in readme, please open a new issue.

Otherwise this is a case of https://xkcd.com/1172

The option is disabled by default for users, unless you have had it enabled before or enabled now, you should not be hearing any sound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sound doesn't work, bell.ogg missing
2 participants