-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify carryoverConcurrencyCount
documentation
#100
Conversation
Updates `carryoverConcurrencyCount` documentation as discussed in issue #99 .
readme.md
Outdated
@@ -105,7 +105,7 @@ The length of time in milliseconds before the interval count resets. Must be fin | |||
Type: `boolean`\ | |||
Default: `false` | |||
|
|||
Whether the task must finish in the given interval or will be carried over into the next interval count. | |||
If `true`, specifies that an incomplete `Promise` should be carried over into the next interval and counted against the `intervalCap`. If `false`, an incomplete promise will continue to run independent of the next interval and will not count towards the `intervalCap`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by incomplete
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A promise that has started executing but hasn't settled yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rafael09ED Can you clarify in the text what you mean by "incomplete" or even better, use a better term than "Incomplete".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How's:
If true
, specifies that any pending Promises, should be carried over into the next interval and counted against the intervalCap
. If false
, any of those pending Promises will not count towards the next intervalCap
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@Rafael09ED Bump |
Do I need to merge |
All good :) |
Updates
carryoverConcurrencyCount
documentation as discussed in issue #99 .