Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify carryoverConcurrencyCount documentation #100

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Clarify carryoverConcurrencyCount documentation #100

merged 2 commits into from
Jul 16, 2020

Conversation

Rafael09ED
Copy link
Contributor

Updates carryoverConcurrencyCount documentation as discussed in issue #99 .

Updates `carryoverConcurrencyCount` documentation as discussed in issue #99 .
readme.md Outdated
@@ -105,7 +105,7 @@ The length of time in milliseconds before the interval count resets. Must be fin
Type: `boolean`\
Default: `false`

Whether the task must finish in the given interval or will be carried over into the next interval count.
If `true`, specifies that an incomplete `Promise` should be carried over into the next interval and counted against the `intervalCap`. If `false`, an incomplete promise will continue to run independent of the next interval and will not count towards the `intervalCap`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by incomplete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A promise that has started executing but hasn't settled yet.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rafael09ED Can you clarify in the text what you mean by "incomplete" or even better, use a better term than "Incomplete".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's:
If true, specifies that any pending Promises, should be carried over into the next interval and counted against the intervalCap. If false, any of those pending Promises will not count towards the next intervalCap.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sindresorhus
Copy link
Owner

@Rafael09ED Bump

@Rafael09ED
Copy link
Contributor Author

Do I need to merge sindresorhus:master into Rafael09ED:patch-1 or would the pull request be fine since the changes are localized to one line?

@sindresorhus sindresorhus merged commit 1e9dcf8 into sindresorhus:master Jul 16, 2020
@sindresorhus
Copy link
Owner

All good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants