Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like this module a lot! I think it would be even better if we were able to define possible resulting errors. I've adding backwards-compatible types for errors here, people might use this when they have known errors being returned by a function.
At seam.co we have really error-heavy code, so we usually have types for all the errors that could be returned by a function. This might be one step towards getting all those errors nicely typed.
Example code BEFORE ErrorType introduced:
Example code after:
I'm interested in comments but I think due to Typescript's all-or-nothing generics this feature might not be very helpful. (see how I have to include APIResponse in the AFTER type above?)