Support AbortController #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
May 24, 2024
| @@ -91,15 +84,16 @@ export default function pThrottle({limit, interval, strict, onDelay}) { | |||
| }); | |||
| }; | |||
|
|
|||
| throttled.abort = () => { | |||
| signal?.throwIfAborted(); | |||
| signal?.addEventListener('abort', () => { | |||
There was a problem hiding this comment.
You need to remove this listener when the function is done, so not to create event listener leaks.
There was a problem hiding this comment.
It seem to have no way to know that the function is done?
|
#53 (comment) is not done |
index.js
Outdated
| queue.get(timeout)(new AbortError()); | ||
| } | ||
| signal?.throwIfAborted(); | ||
| if (signal && !signal.aborted) { |
There was a problem hiding this comment.
The aborted check is moot as throwIfAborted already takes care of that.
|
I think you could use https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/FinalizationRegistry to unsubscribe when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51