add prototype support #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SamVerschueren See #16. |
|
Damn, should've looked better. Title of the PR wasn't entirely clear. Thanks for pointing that out. |
|
@SamVerschueren Any feedback on that PR more than welcome! I haven't had a chance to review it yet. Let's discuss the flag thing there. |
|
@sindresorhus sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed #14 as well. Not sure if their are any downsides by using
for...ininstead ofObject.keys()?@sindresorhus you talked about a boolean flag for promisifying prototype methods or not. Do you still want that? Don't really feel the need for a flag to be able to turn it on or off. So feedback is more then welcome.