Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to support non-error-first APIs #42

Merged
merged 1 commit into from
May 27, 2017
Merged

Add option to support non-error-first APIs #42

merged 1 commit into from
May 27, 2017

Conversation

sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Apr 18, 2017 •
edited
Loading

Fixes #31

Use this for review to ignore indentation changes:
https://github.com/sindresorhus/pify/pull/42/files?w=1

I'm not totally sold on the errorFirst option name. Any better suggestions?

@schnittstabil
Copy link
Contributor

I'm not totally sold on the errorFirst option name. Any better suggestions?

I'm afraid not.

I've tried to reduce the complexity of processFn a bit (see schnittstabil@0c26e34) – but I'm wondering whether or not it is really worth it.

SamVerschueren
SamVerschueren approved these changes Apr 18, 2017
View reviewed changes
Copy link
Contributor

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really come up with a better name for errorFirst either. It's also what it does though, it's called error first callbacks for a reason :).

@sindresorhus
Copy link
Owner Author

I've tried to reduce the complexity of processFn a bit (see schnittstabil/pify@0c26e34) – but I'm wondering whether or not it is really worth it.

Not really worth it. When we target Node.js 6, we can simplify it a lot. Until then, I can live with it being a bit un-DRY.

@patrickdronk
Copy link

When is this going to be merged?

@sindresorhus sindresorhus merged commit fad7b3d into master May 27, 2017
@sindresorhus sindresorhus deleted the non-error-first branch May 27, 2017 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schnittstabil schnittstabil schnittstabil approved these changes

@SamVerschueren SamVerschueren SamVerschueren approved these changes

@jamestalmage jamestalmage Awaiting requested review from jamestalmage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sindresorhus @schnittstabil @patrickdronk @SamVerschueren