Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary option #60

Merged
merged 8 commits into from
Aug 29, 2020
Merged

Add binary option #60

merged 8 commits into from
Aug 29, 2020

Conversation

nmoinvaz
Copy link
Contributor

This code is not mine but I am submitting so this feature gets into mainline.

@nmoinvaz nmoinvaz force-pushed the master branch 2 times, most recently from 63d5b01 to 75676a3 Compare August 11, 2020 21:38
@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented Aug 11, 2020

Looks like there is a bug in the CI due to Node 6 support and full-icu library.

@nmoinvaz nmoinvaz force-pushed the master branch 7 times, most recently from aa594a0 to 8f3bfe3 Compare August 12, 2020 00:37
index.d.ts Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Make sure running $ npm test locally passes.

@sindresorhus sindresorhus changed the title Added binary option to enable 1024 based counting. Add binary option Aug 16, 2020
@nmoinvaz
Copy link
Contributor Author

nmoinvaz commented Aug 23, 2020

I had to modify npm test command to get it to work on Windows using cross-env package/command. I can submit a separate PR for that, however cross-env does not work on Node 6 and Travis is configured to Node 6. Well I suppose your Travis CI script is not working on Node 6 anyways.

@sindresorhus sindresorhus merged commit 4ef01f4 into sindresorhus:master Aug 29, 2020
test.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants