Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ports section to readme #186

Merged
merged 3 commits into from
Jan 20, 2016
Merged

Conversation

edouard-lopez
Copy link
Contributor

@edouard-lopez edouard-lopez mentioned this pull request Jan 19, 2016
@mafredri
Copy link
Collaborator

I don't know which is better, to list all the ports in the readme and remove them from the Wiki or just link to the Wiki from the readme?

As it stands there is duplicate info and two lists to maintain.

@@ -161,6 +161,17 @@ antibody bundle mafredri/zsh-async
antibody bundle sindresorhus/pure
```

## Shell Ports
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shell here is superfluous (and could be understood as pure is not for the shell), pure is a shell theme and thus these are just ports.

@edouard-lopez
Copy link
Contributor Author

I think it better to remove the wiki, just keep a minimal list and let each repo provide screenshots and descriptions.

@sindresorhus
Copy link
Owner

Place it below the FAQ section.

@mafredri mafredri changed the title add Shell Ports section Add Ports section to readme Jan 20, 2016
@mafredri
Copy link
Collaborator

Looks good to me 👍!

mafredri added a commit that referenced this pull request Jan 20, 2016
@mafredri mafredri merged commit 45ef73e into sindresorhus:master Jan 20, 2016
@zmwangx
Copy link
Contributor

zmwangx commented Jan 20, 2016

Well, should have been squashed... (I subscribe to pure's commits feed and these three commits in a row including two apparent fixups were pretty hard to make sense of until I came to this PR and saw the full picture.) But since it already landed on master...

@mafredri
Copy link
Collaborator

Sorry about that @zmwangx (and everyone else). I noticed it myself after I had hit the merge button, but it was too late 😧.

@zmwangx
Copy link
Contributor

zmwangx commented Jan 20, 2016

No problem! I know the big merge button is inviting 😉

@edouard-lopez
Copy link
Contributor Author

I make them through the web interface as they where minor/doc edit.

For future PR, is there a way to squash them through web UI?

@sindresorhus
Copy link
Owner

@edouard-lopez No, but you could use http://rebaseandsqua.sh/

@zmwangx
Copy link
Contributor

zmwangx commented Jan 20, 2016

There's an unofficial feature request for this: isaacs/github#406.

@edouard-lopez edouard-lopez deleted the patch-1 branch February 26, 2016 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants