-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ports section to readme #186
Conversation
I don't know which is better, to list all the ports in the readme and remove them from the Wiki or just link to the Wiki from the readme? As it stands there is duplicate info and two lists to maintain. |
@@ -161,6 +161,17 @@ antibody bundle mafredri/zsh-async | |||
antibody bundle sindresorhus/pure | |||
``` | |||
|
|||
## Shell Ports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shell
here is superfluous (and could be understood as pure is not for the shell), pure is a shell theme and thus these are just ports.
I think it better to remove the wiki, just keep a minimal list and let each repo provide screenshots and descriptions. |
Place it below the FAQ section. |
Looks good to me 👍! |
Well, should have been squashed... (I subscribe to pure's commits feed and these three commits in a row including two apparent fixups were pretty hard to make sense of until I came to this PR and saw the full picture.) But since it already landed on master... |
Sorry about that @zmwangx (and everyone else). I noticed it myself after I had hit the merge button, but it was too late 😧. |
No problem! I know the big merge button is inviting 😉 |
I make them through the web interface as they where minor/doc edit. For future PR, is there a way to squash them through web UI? |
@edouard-lopez No, but you could use http://rebaseandsqua.sh/ |
There's an unofficial feature request for this: isaacs/github#406. |
see sindresorhus/pure#183.