Add TypeScript definition #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 Sounds like the best solution. I can wait for that PR. |
sindresorhus
reviewed
Mar 2, 2019
sindresorhus
reviewed
Mar 2, 2019
This is fixed now. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure, whether it's a good idea to define types in
index.d.tswhile the main JS is insrc/screenfull.js.I'd actually prefer to put the types along the main JS file in
src/screenfull.d.tsand extend thegruntconfig to copy this file over todist.The only problem to this is that
tsd-checkcurrently has two bugs preventing this. I've opened a PR with a fix, so if you want me to follow this path, we will have to wait for a new release oftsd-check.