Stop making non-Error properties non-enumerable (#102)

index.js

@@ -16,7 +16,7 @@ export class NonError extends Error {
 	}
 }
 
-const commonProperties = [
+const errorProperties = [
 	{
 		property: 'name',
 		enumerable: false,
@@ -127,14 +127,16 @@ const destroyCircular = ({
 		to[key] = '[Circular]';
 	}
 
-	for (const {property, enumerable} of commonProperties) {
-		if (from[property] !== undefined && from[property] !== null) {
-			Object.defineProperty(to, property, {
-				value: isErrorLike(from[property]) ? continueDestroyCircular(from[property]) : from[property],
-				enumerable: forceEnumerable ? true : enumerable,
-				configurable: true,
-				writable: true,
-			});
+	if (serialize || to instanceof Error) {
+		for (const {property, enumerable} of errorProperties) {
+			if (from[property] !== undefined && from[property] !== null) {
+				Object.defineProperty(to, property, {
+					value: isErrorLike(from[property]) ? continueDestroyCircular(from[property]) : from[property],
+					enumerable: forceEnumerable ? true : enumerable,
+					configurable: true,
+					writable: true,
+				});
+			}
 		}
 	}
 

test.js

@@ -279,7 +279,7 @@ for (const property of ['cause', 'any']) {
 	});
 }
 
-test('deserialized name, stack, cause and message should not be enumerable, other props should be', t => {
+test('deserialized Error class properties should not be enumerable, other props should be', t => {
 	const object = {
 		message: 'error message',
 		stack: 'at <anonymous>:1:13',
@@ -297,6 +297,10 @@ test('deserialized name, stack, cause and message should not be enumerable, othe
 		errno: 1,
 		syscall: 'syscall',
 		randomProperty: 'random',
+		notAnError: {
+			stack: 'Not an error',
+			cause: 'Wasn’t me',
+		},
 	};
 
 	const deserialized = deserializeError({...object, ...enumerables});
@@ -305,6 +309,11 @@ test('deserialized name, stack, cause and message should not be enumerable, othe
 		Object.keys(enumerables),
 		Object.keys(deserialized),
 	);
+
+	t.deepEqual(
+		Object.keys(enumerables.notAnError),
+		Object.keys(deserialized.notAnError),
+	);
 });
 
 test('should deserialize properties up to `Options.maxDepth` levels deep', t => {