-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting languages into loadable dictionaries and adding Swedish language #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the user having to manually load the wanted dictionaries, I think it would be better if the user could just provide a language hint, for example, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @sindresorhus !
This PR improves the management of languages through dictionaries.
Users can now explicitly load the dictionary-ies they need to properly slugify their data.
This PR was needed because of languages overlapping.
For example, Swedish and German have common chars (such as Ä), and thus the wrong replacements were made.
It is now fixed, and thus fixes #33
Also, this PR adds support for a lot of new languages, with according tests, to amend long-pending PRs:
armenian
czech
dhivehi
georgian
greek
hungarian
latin
latvian
lithuanian
macedonian
polish
serbian
slovak
ukrainian
Thanks for the good work!