Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a prefix for temp directory #20

Merged
merged 15 commits into from
Jul 18, 2020

Conversation

Richienb
Copy link
Contributor

@Richienb Richienb commented Jan 18, 2020

Signed-off-by: Richie Bendall richiebendall@gmail.com

cc @sindresorhus

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@sindresorhus
Copy link
Owner

What's the use-case for this? What problem are you trying to solve?

@Richienb
Copy link
Contributor Author

@sindresorhus

Allow developers to easily find the cache directories created by a particular application for faster debugging.

@sindresorhus
Copy link
Owner

Debugging of what? Can you describe how you would use this for debugging? Just a name prefix will not help much as there will probably be more than one directory.

@Richienb
Copy link
Contributor Author

@sindresorhus Having a prefix would allow us to know which application created the directory.

@sindresorhus
Copy link
Owner

Yes, but what do you do with that information?

@Richienb
Copy link
Contributor Author

Richienb commented Feb 22, 2020

@sindresorhus

Yes, but what do you do with that information?

In my use case, my script automatically downloads and extracts a ffmpeg binary to a temporary path so, with a directory prefix, I can easily find the directory that it downloaded it to in order to check that it actually worked.

@Richienb Richienb changed the title feat: Allow setting a prefix for temp directory Allow setting a prefix for temp directory Feb 22, 2020
index.d.ts Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
Richienb and others added 7 commits July 17, 2020 14:50
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@Richienb Richienb requested a review from sindresorhus July 17, 2020 03:05
@Richienb
Copy link
Contributor Author

@sindresorhus Ready for re-review!

@sindresorhus
Copy link
Owner

Travis is failing

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants