Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56 .
The changes are:
%Y-%m-%dT%H:%M:%S
in the local time.You can check the trash implementation in GNOME: https://gitlab.gnome.org/GNOME/glib/blob/glib-2-56/gio/glocalfile.c .
A code starting at line 2195 shows the appropriate style of trash info:
As for the second change, a comment starting at line 2181 is helpful. This comment and discussion ( https://bugzilla.gnome.org/show_bug.cgi?id=749314 ) shows the appropriate order of moveFile and writeFile.
I confirmed that the fixed code worked fine in Ubuntu 18.04. When I reverse the order of moveFile and writeFile in js, I always reproduce the hashed filename issue.
IssueHunt Summary
Referenced issues
This pull request has been submitted to: