-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not skipLibCheck #15
Comments
But with lib skip off, checking becomes much slower... Is there any way to only check local files and ignore other packages? If not, might be worth opening a TS issue. |
I had interpreted / remembered this option as meaning that types within dependencies weren't checked to be correct, only ones defined in ones own project, but the quote above is from the docs, so I agree, it's not good to have. See: https://www.typescriptlang.org/tsconfig#skipLibCheck |
Yeah I suppose the intended use of d.ts is to share types across libraries rather than locally, hence the skip LIB check. In the past I enabled this flag (in an attempt) to fix some node_modules issues too, but I don't remember if it was effectively. Disabling it might bring those back (however I disabled it in a couple of large projects without issue) |
So – ran into this again in Whenever one handcrafts |
Another victim of Inadvertently makes Would have been caught if this config would disable (I’ll report a proper issue in |
I'm currently looking into using
d.ts
files as a way to declare some types using imports from libraries without risking to import the libraries themselves.Example:
Did you catch that? TypeScript didn't. The
.d.ts
file above "passes"tsc
validation buttypeof eslint
is spelled astypeof ESIINT
.Use
skipLibCheck: false
and it works:The text was updated successfully, but these errors were encountered: