-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tsd
(and pin TypeScript to current minor)
#839
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d91f7b7
Update `tsd` (and pin TypeScript to current minor)
voxpelli 19c859f
Update package.json
sindresorhus f666556
Merge branch 'main' into update-tsd
sindresorhus 9ec189d
Merge branch 'main' into update-tsd
sindresorhus bb4f432
Merge branch 'main' into update-tsd
voxpelli 7aa8c51
Add test case for `HasMultipleCallSignatures`
voxpelli 8107aae
Fix `HasMultipleCallSignatures`
voxpelli 48ec728
Fix for tests
voxpelli 0939cce
Merge remote-tracking branch 'origin/main' into update-tsd
voxpelli e94d9d3
Fix `WriteableDeep` compatibility with TS 5.4
voxpelli e5886b2
Fix linting
voxpelli 8aaca8d
Fix edge case in `HasMultipleCallSignatures`
voxpelli e846f47
Add explicit test for `WritableDeep` as well
voxpelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import {expectType} from 'tsd'; | ||
import type {HasMultipleCallSignatures} from '../../source/internal'; | ||
|
||
type Overloaded = { | ||
(foo: number): string; | ||
(foo: string, bar: number): number; | ||
}; | ||
|
||
type Overloaded2 = { | ||
(foo: number | undefined): string; | ||
// eslint-disable-next-line @typescript-eslint/unified-signatures | ||
(foo: number): string; | ||
}; | ||
|
||
type Namespace = { | ||
(foo: number): string; | ||
baz: boolean[]; | ||
}; | ||
|
||
expectType<true>({} as HasMultipleCallSignatures<Overloaded>); | ||
expectType<true>({} as HasMultipleCallSignatures<Overloaded2>); | ||
expectType<false>({} as HasMultipleCallSignatures<Namespace>); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to add a test to
test-d/writable-deep.ts
too? So it doesn't regress again in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sindresorhus Sure, there is a test already, but most tests in both of these are indirect ones which gives some cascading one, I'll add en explicit one 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sindresorhus Done ✔️