Merge pull request #98 from jonasschumacher/feature/chromium-edge

Add check for Chromium based Edge, resolves #94
sinergi · Sep 23, 2021 · 4927f7c · 4927f7c
2 parents 16cad9c + fba53a8
commit 4927f7c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/BrowserDetector.php b/src/BrowserDetector.php
@@ -462,6 +462,14 @@ public static function checkBrowserEdge()
             }
             self::$browser->setName(Browser::EDGE);
 
+            return true;
+        } elseif (stripos(self::$userAgentString, 'Edg') !== false) {
+            $version = explode('Edg/', self::$userAgentString);
+            if (isset($version[1])) {
+                self::$browser->setVersion(trim($version[1]));
+            }
+            self::$browser->setName(Browser::EDGE);
+
             return true;
         }
 

diff --git a/tests/BrowserDetector/Tests/_files/UserAgentStrings.xml b/tests/BrowserDetector/Tests/_files/UserAgentStrings.xml
@@ -274,5 +274,17 @@
                 Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/534.34 (KHTML, like Gecko) wkhtmltopdf-amd64 Safari/534.34
             </field>
         </string>
+        <string>
+            <field name="browser">Edge</field>
+            <field name="version">80.0.361.40</field>
+            <field name="os">Windows</field>
+            <field name="os_version">10.0</field>
+            <field name="device">unknown</field>
+            <field name="device_version">unknown</field>
+            <field name="string">
+                Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.66
+                Safari/537.36 Edg/80.0.361.40
+            </field>
+        </string>
     </strings>
 </document>