Update jsonschema version range. #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
I also created a separate placeholder PR for updating |
2 tasks
|
I also added another PR in |
|
I also added a PR in |
|
I also added a PR in |
|
Finally, added in the |
|
Thanks @manavkohli for continuing it :) 👍 |
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This includes the same changes as in #123, however, I signed the contribution agreement. This dependency issue precludes the use of any singer taps/targets with Google Cloud Composer since the builds fail with
jsonschemaversion incompatibilities. This change will also avoid confusion for those viewing the Stitch Medium post Superching ETL with Airflow and Singer. For those hosting Airflow themselves, @feluelle further describes the motivations for the change:"Airflow 1.10.7 added the jsonschema dependency to support serializing/deserialising data in its meta database.
Because singer-python pins the jsonschema version to 2.6.0, it can no longer be used in Airflows newer versions in the same Python venv.
This change would allow users to use singer-python in a newer Airflow Environment."
Manual QA steps
Risks
Rollback steps