Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse dev mode argument #158

Merged
merged 4 commits into from
Nov 3, 2022
Merged

parse dev mode argument #158

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b470f8a
parse dev mode argument
Sep 21, 2022
b41e05f
update the short flag for dev mode
RushiT0122 Sep 27, 2022
1ed70b6
Updated the short flag for dev mode
RushiT0122 Sep 28, 2022
f32f7d1
- remove dev mode short flag
Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion singer/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def strptime(dtime):
...
ValueError: time data '2018-01-01T00:00:00' does not match format '%Y-%m-%dT%H:%M:%SZ'

Can't parse non-UTC DTs
Can't parse non-UTC DTsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an errant x committed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted errant x.

>>> strptime("2018-01-01T00:00:00-04:00")
Traceback (most recent call last):
...
Expand Down Expand Up @@ -134,6 +134,7 @@ def parse_args(required_config_keys):
-d,--discover Run in discover mode
-p,--properties Properties file: DEPRECATED, please use --catalog instead
--catalog Catalog file
-D, --dev Runs the tap in dev mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest that having a shortcode for this isn't useful since it reduces readability at the savings of 3 characters, maybe if it was --developer-mode or something, but this feels like it would just lead to folks not knowing what the -D means and copy/pasting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On that note, maybe not critical right now, but the docstring above the changed lines mentions the SPEC and BEST_PRACTICES documents in the getting started repo, so it might be good to eventually update those.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the short flag -D.


Returns the parsed args object from argparse. For each argument that
point to JSON files (config, state, properties), we will automatically
Expand Down Expand Up @@ -163,6 +164,11 @@ def parse_args(required_config_keys):
action='store_true',
help='Do schema discovery')

parser.add_argument(
'-dev', '--dev',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs to be changed here too

action='store_true',
help='Runs tap in dev mode')

args = parser.parse_args()
if args.config:
setattr(args, 'config_path', args.config)
Expand Down