Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream_alias to Catalog.to_dict #61

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

flash716
Copy link
Contributor

stream_alias is a property on CatalogEntry but does not currently get dumped out in to_dict.

test_catalog updated to test for cases where stream_alias is included and excluded.

Copy link
Contributor

@nick-mccoy nick-mccoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@nick-mccoy nick-mccoy merged commit c5182e9 into singer-io:master Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants