changing strftime format string #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to this issue #59
Some C Libraries version of strftime() recognize a field width modifier in the format string, e.g. the
04in%04Y-%m-%dT%H:%M:%S.%fZwhich specifies the width of the year field.We added this
04to our date format to ensure that dates with years < 1000 still have a 4 digit year.However, other C Libraries do not recognize this field width modifier, but zero pad dates with years < 1000 to ensure they are 4 digits long.
To remedy this inconsistency, the
04is being removed from the date format string, and an optional argument is being added to singer.utils.strftime() so callers of that function can supply their own date format string.