Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Test insights, add retry logic to insights job #124

Merged
merged 1 commit into from
Jan 25, 2021
Merged

added Test insights, add retry logic to insights job #124

merged 1 commit into from
Jan 25, 2021

Conversation

luandy64
Copy link
Contributor

Description of change

Add to the backoff decorator a check for a FacebookBadObjectError

Manual QA steps

  • Wrote and ran a unit test

Risks

  • Low: This should not interfere with a normal tap run. In the case that a FacebookBadObjectError is raised, we should be able to retry it successfully (since the unit tests pass)

Rollback steps

  • revert this branch

@leslievandemark leslievandemark merged commit 0ef8f87 into master Jan 25, 2021
@leslievandemark leslievandemark deleted the retryinsights branch January 25, 2021 18:09
@luandy64 luandy64 mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leslievandemark leslievandemark leslievandemark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luandy64 @leslievandemark