Change remote_read to api_get #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KAllan357
approved these changes
Oct 17, 2019
bradcosine
pushed a commit
to LullCode/tap-facebook
that referenced
this pull request
Jan 16, 2020
* Add Designated Market Area (DMA) breakdown for Insights report Fixes singer-io#45 * Revert "Add Designated Market Area (DMA) breakdown for Insights report" * Add ads_insights_dma.json * Add ads_insights_dma.json * Revert "Merge pull request singer-io#63 from singer-io/revert-62-facebook_dma" This reverts commit 9954380, reversing changes made to 4db3088. * version 1.6.0 * Switched from annotated schema to metadata (singer-io#67) * Switched from annotated schema to metadata * empty commit for testing * Fix unit tests and run integration tests in circle * Bump to v1.7.0, Changelog update * Bump `facebook_business` version (singer-io#68) * Update facebook_business dependency * Remove deprecated video_p95_watched_actions field from schemas See https://developers.facebook.com/ads/blog/post/2018/07/31/mapi-video-metrics/ * Bump to v1.7.1 with changelog update * Change remote_read to api_get (singer-io#69) * update changelog * Add PR template * SUP-956: Limit API request to avoid 500 (singer-io#71) * Update RESULT_RETURN_LIMIT if passed in from config * WIP: Date windowing on adcreative stream * Undo changes to state * Simplify result_return_limit override * Add a comment * Include end date in the sync * Bump to v1.8.0, update changelog (singer-io#72) * modify AdCreative stream to sync via batch API (singer-io#73) * bump to 1.8.1 (singer-io#74) * SRCE-1867: Add tap-tester tests (singer-io#75) * Prepare for tap-tester tets to live in /tests * Add tap-tester tests * add `video_play_curve_actions` to ads_insights schemas (singer-io#80) * add `video_play_curve_actions` to ads_insights schemas * add ads_histogram_stats.json shared schema * bump version to 1.8.2 (singer-io#81) * update pip (singer-io#82) Co-authored-by: Diego Fernández Giraldo <aiguo.fernandez@gmail.com> Co-authored-by: Christopher Merrick <cmerrick@talend.com> Co-authored-by: cosimon <cosimon@users.noreply.github.com> Co-authored-by: Andy Lu <luandy64@gmail.com> Co-authored-by: Kyle Allan <KAllan357@gmail.com> Co-authored-by: Nick McCoy <33731945+nick-mccoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
remote_read()is a deprecated function and the upgrade seems to be to useapi_get()QA steps
tap-testeris passingRisks
Data discrepancies for anyone using
tap-facebookRollback steps